In article <[EMAIL PROTECTED]> (at Fri, 22 Jul 2005 23:21:51 +0200), Petr 
Baudis <[EMAIL PROTECTED]> says:


> this whole getaddrinfo() magic looks horribly complicated. What's wrong
> on just adding a similar code (or factoring it out to a function) for
> IPv6 as there is for IPv4, just s/INET/INET6/?

Because it is the Good Way To Go; protocol independent programming.


> > -                           die("accept returned %s", strerror(errno));
> > +           struct sockaddr_storage ss;
> > +           socklen_t sslen = sizeof(ss);
> 
> Perhaps move those to the most inner block. (All right, I'm nitpicking
> too much again, sorry.)
> 

okay.

> > +             if (select(maxfd + 1, &fds, NULL, NULL, NULL) == -1) {
> > +                     /* warning? */
> 
> Certainly a warning and at least sleep(1) to avoid cpuburn-like
> behaviour in case of anything going wrong.

okay...

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to