Pavel Roskin <[EMAIL PROTECTED]> writes:

> This patch does following:
> All instances of "exit", "exit 1" and "(exit 1)" in tests have been
> replaced with "return 1".  In fact, "(exit 1)" had no effect.

Are you sure about all of the above?

You are right about "... || exit" in the expect_success tests;
they are broken.  But '(exit 1)' or just saying 'false' at the
end should have done the right thing.  Worse yet, return does
not seem to really work as expected, except if all you want to
do was to tell the test driver "I failed", in which case
"bloopl" would work just as well.

prompt$ cat
eval '
        echo foo
        case '$what' in
                (exit 1) ;;
                exit 1 ;;
                return 1 ;;
echo "status $?"
prompt$ bash exit
prompt$ bash false
status 1
prompt$ bash return
foo line 20: return: can only `return' from a function or sourced script
status 1

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to