Jiang Xin <[email protected]> writes:
> Mark strings in 'git-am.sh' for translation. In the last chunk, I
> changed '$1' to '-b/--binary' for this reason:
>
> * First, if there is a variable in the l10n message, we could not use
> gettext. Because the variable will be expanded (evaluated) and will
> never match the entry in the po file.
>
> * Second, if there is a positional parameter ($1, $2,...) in the
> message, we could not use eval_gettext either. Because eval_gettext
> may be a wapper for gettext, and the positional parameter would
> lose its original context.
>
> Also reduce one indentation level for one gettextln clause introduced
> in commit de88c1c.
>
> Signed-off-by: Jiang Xin <[email protected]>
> Reviewed-by: Stefano Lattarini <[email protected]>
> Reviewed-by: Jonathan Nieder <[email protected]>
Thanks. I've reworded the rationale for -b/--binary, though, as the
above sounds as if we are clueless as to how to i18n this message
properly even if we wanted to, which is not the case.
Mark strings in 'git-am.sh' for translation. In the last chunk,
change '$1' to '-b/--binary', as it is not worth turning this
message to "The %s option has been..." and using printf on it.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
