On Mon, Jul 30, 2012 at 01:10:10PM -0300, Daniel Graña wrote:

> Subject: Re: [PATCH] Improve tests for detached worktree in git-submodule
> Signed-off-by: Daniel Graña <dan...@gmail.com>

The space between the subject and your S-o-b is an excellent place to
explain the rationale for your commit.

How are we improving them? What cases or classes of failure does this
catch that the original did not?  It may be because I have not been
following this topic closely, but reading the patch, I am not sure what
the purpose is. Please make life easier for reviewers by telling us what
to expect and why before we even get to the patch.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to