Ben Walton <bwal...@artsci.utoronto.ca> writes:

> Now that git_terminal_prompt can cleanly interact with /dev/tty on
> Solaris, enable HAVE_DEV_TTY so that this code path is used for
> credential reading instead of relying on the crippled getpass().
>
> Signed-off-by: Ben Walton <bwal...@artsci.utoronto.ca>
> ---
>
> This is a follow up to Jeff's patch that fixes git_terminal_prompt on
> Solaris.  I don't have 5.6 or 5.7 for testing but I believe this
> should be valid for both of those releases as well.

So which direction do you guys want to go?  Use the "bidirectional
stdio with fseek()" for now, with the expectation that Tay's other
series will rewrite it to fd based one?

>
>  Makefile |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 15d1319..6b0c961 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1014,6 +1014,7 @@ ifeq ($(uname_S),SunOS)
>       NO_REGEX = YesPlease
>       NO_FNMATCH_CASEFOLD = YesPlease
>       NO_MSGFMT_EXTENDED_OPTIONS = YesPlease
> +     HAVE_DEV_TTY = YesPlease
>       ifeq ($(uname_R),5.6)
>               SOCKLEN_T = int
>               NO_HSTRERROR = YesPlease
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to