[PATCH 2/3] read-cache.c: Pass 'struct stat' parameters by reference

[Ramsay Jones]

Signed-off-by: Ramsay Jones <ram...@ramsay1.demon.co.uk>
---

Hi Thomas,

Passing the 'struct stat' parameters by value, while not *wrong*, looks
somewhat odd to my eyes. As I said before, feel free to ignore this one.

ATB,
Ramsay Jones

 read-cache.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/read-cache.c b/read-cache.c
index 211b971..36f0877 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1199,25 +1199,25 @@ int read_index(struct index_state *istate)
        return read_index_from(istate, get_index_file());
 }
 
-static int index_changed(struct stat st_old, struct stat st_new)
+static int index_changed(struct stat *st_old, struct stat *st_new)
 {
        int changed = 0;
 
-       if (st_old.st_mtime != st_new.st_mtime ||
+       if (st_old->st_mtime != st_new->st_mtime ||
 #if !defined(__CYGWIN__)
-           st_old.st_uid   != st_new.st_uid ||
-           st_old.st_gid   != st_new.st_gid ||
-           st_old.st_ino   != st_new.st_ino ||
+           st_old->st_uid   != st_new->st_uid ||
+           st_old->st_gid   != st_new->st_gid ||
+           st_old->st_ino   != st_new->st_ino ||
 #endif
-           st_old.st_size  != st_new.st_size)
+           st_old->st_size  != st_new->st_size)
                changed = 1;
 #ifdef USE_NSEC
-       if (ST_MTIME_NSEC(st_old) != ST_MTIME_NSEC(st_new))
+       if (ST_MTIME_NSEC(*st_old) != ST_MTIME_NSEC(*st_new))
                changed = 1;
 #endif
 
 #ifdef USE_STDEV
-       if (st_old.st_dev != st_new.st_dev)
+       if (st_old->st_dev != st_new->st_dev)
                changed = 1;
 #endif
 
@@ -1273,12 +1273,12 @@ int read_index_from(struct index_state *istate, const 
char *path)
 
                munmap(mmap, mmap_size);
 
-               if (!index_changed(st_old, st_new) && !err)
+               if (!index_changed(&st_old, &st_new) && !err)
                        return istate->cache_nr;
 
                usleep(10*1000);
                i++;
-       } while ((err || index_changed(st_old, st_new)) && i < 50);
+       } while ((err || index_changed(&st_old, &st_new)) && i < 50);
 
        munmap(mmap, mmap_size);
        die("index file corrupt");
-- 
1.7.12

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html