Junio C Hamano venit, vidit, dixit 12.09.2012 19:25: > Michael J Gruber <g...@drmicha.warpmail.net> writes: > >> It was introduced in 0ab7befa with a clear meaning (AND everything), >> then the general logic (without --all-match) was modified in 80235ba7 >> (to take headermatch AND (all greps ORed)), and 5aaeb733 finally made >> multiple authors resp. committers get ORed among each other. All of this >> in an attempt to make the standard usage most useful, of course. As a >> consequence, --all-match does not influence multiple --author options at >> all (contrary to the doc), e.g. >> >> I don't see any of this reflected in the doc, though. I noticed only by >> reading t/t7810-grep.sh. Before that, I had only gone by my own testing >> which didn't reveal the multiple author multiple special casing effect. >> >> I guess I'll have to wrap my head around the current implementation a >> few more times before trying to describe the status quo in the >> documentation... > > This is what I used to use when adding these generalized grep > boolean expressions. > > With this applied, you can try things like these: > > $ git log --grep=regexp --grep=nosuch --all-match >/dev/null > $ git log --grep=regexp --grep=nosuch --author=Michael >/dev/null > > For example, "--all-match --grep=regexp --author=Michael --author=Linus" turns > into > > [all-match] > (or > pattern_body<body>regexp > (or > (or > pattern_head<head 0>Linus > pattern_head<head 0>Michael > ) > true > ) > ) > > that says "body must have 'regexp' in it, and authored by either > Linus or Michael". > > The semantics of "--all-match" is different from "--and" (which, > together with "--or", ")", and "(", is not availble to rev-list > command line parser primarily because "--not" is not available). > After applying all the "or"-ed terms, it checks the top-level nodes > that are "or"-ed and makes sure all of them fired (possibly and > usually on different lines).
Thanks for "this" ;) I'll recheck my understanding and update the doc then. Maybe even putting the above in-tree with a "--debug" option seems inline with things such as "git describe --debug" (and maybe a preparation for exposing a richer interface). Michael -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html