On Fri, Sep 14, 2012 at 7:44 PM, Jeff King <p...@peff.net> wrote:
> On Fri, Sep 14, 2012 at 06:41:45PM +0200, Erik Faye-Lund wrote:
>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>> index 78c4286..7d1b34b 100644
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -129,6 +129,20 @@ export _x05 _x40 _z40 LF
>> # This test checks if command xyzzy does the right thing...
>> # '
>> # . ./test-lib.sh
>> +if ! which tput > /dev/null ; then
> Testing the return value of "which" is not portable (I know, it's
> insane; SunOS is the common offender). Use "type" instead.
Junio already noticed it, and I suggested a fix that involved running
it. However, I like your fix much better, thanks :)
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html