In particular, sparse complains that "... 'dump_grep_expression'
was not declared. Should it be static?". In order to suppress
the warning, since this function does not need more than file
scope, we simply include the static modifier in it's declaration.

Signed-off-by: Ramsay Jones <>

Hi Junio,

I prefer to catch these before they progress to next, but it seems
I've not been quick enough lately! Sorry about that. :(  [I will have
to git-fetch more frequently; at present I only fetch about 3 times
a week.]

I've been away for a few days, so I'm well behind ... (I'm just
about to download 350+ emails for me to read tonight!).

Ramsay Jones

 grep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grep.c b/grep.c
index 925aa92..38c4d75 100644
--- a/grep.c
+++ b/grep.c
@@ -403,7 +403,7 @@ static void dump_grep_expression_1(struct grep_expr *x, int 
-void dump_grep_expression(struct grep_opt *opt)
+static void dump_grep_expression(struct grep_opt *opt)
        struct grep_expr *x = opt->pattern_expression;

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to