On Thu, Sep 20, 2012 at 8:21 PM, Jeff King <p...@peff.net> wrote:
> On Thu, Sep 20, 2012 at 08:11:52PM +0200, SZEDER Gábor wrote:
>> > > In order to achieve that I took bash-completion's quote() function,
>> > > which is rather simple, and renamed it to __git_quote() as per Jeff
>> > > King's suggestion.
>> > >
>> > > Solves the original problem for me.
>> > Me too. Thanks.
>> While it solves the original problem, it seems to break refs
>> completion, as demonstrated by the following POC test:
>> diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
>> index 92d7eb47..fab63b95 100755
>> --- a/t/t9902-completion.sh
>> +++ b/t/t9902-completion.sh
>> @@ -228,4 +228,11 @@ test_expect_success 'general options plus command' '
>> test_completion "git --no-replace-objects check" "checkout "
>> +test_expect_success 'basic refs completion' '
>> + touch file &&
>> + git add file &&
>> + git commit -m initial &&
>> + test_completion "git branch m" "master "
> Hmm. I notice that Felipe's patch wraps the _whole_ input to
> __gitcomp_nl in single quotes.
Wasn't there a patch series that added tests for __gitcomp_nl to catch
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html