> It largely depends on how the user would interact with your program, > which is totally unclear as we haven't seen any part of it. I do > not think we have enough information to answer the question at this > point.
Do you mean it largely depends on the diversity of options on input and output formats? Currently I just take a path and output lists like: 53: (1da177e4c3f41524e886b7f1b8a0c1fc7321cac2,Linus Torvalds) (201b6264ff3865090747f58f48e087c3a35e0dbc,Christoph Lameter) (e2bdb933ab8b7db71c318a4ddcf78a9fffd61ecb,Hugh Dickins) 54: (7cf9c2c76c1a17b32f2da85b50cd4fe468ed44b5,Nick Piggin) (e2bdb933ab8b7db71c318a4ddcf78a9fffd61ecb,Hugh Dickins) 55: (e2bdb933ab8b7db71c318a4ddcf78a9fffd61ecb,Hugh Dickins) 56: (1da177e4c3f41524e886b7f1b8a0c1fc7321cac2,Linus Torvalds) This shows for all lines in the specified file, all commits that have changed a line. I know this is not enough for a tool. So this is case, does "how the user would interact with your program" mean that I should add more options like which revision to start, some parameters in the algorithm, choice on different diff algorithms, and options for customizing the contents of output? > If it is a trivial script that largely depends on what we already > ship, I would not mind carrying it in contrib/. If it is anything > substantial and substantially useful, however, I would suspect that > you are better off not be in in my tree, but rather want to be > independent. Finishing it to be useful for your purpose, publishing > it somewhere people can take a look at and adding a pointer to > https://git.wiki.kernel.org/index.php/InterfacesFrontendsAndTools is > probably where you would want to start. I think it would be helpful for our discussion if I first briefly introduce my approach. It starts at the current head and tracks all the lines in the specified file. It then goes along the commit graph topologically. For any two commits A and B connected by an edge from A to B (commit B is the parent of commit A) and if A is not a merge commit, it first calls the tree-diff interface to get the added lines in A and deleted lines in B, and detect renaming. Then it applies ldiff algorithm (http://sourceforge.net/projects/ldiff/ . It is in perl. I adapt it into c in my program) to match the added lines and deleted lines. The result is that now we have some added lines, some deleted lines and some changed lines. For added lines, I know the this commit is the last one to change it. For changed lines, I add this commit to the final result and keep tracking them. Currently I ignore those deleted lines. But if A is a merge commit, it doesn't change authorship except for merge conflicts. I did start with implementing my approach with python. The script keeps calling git-log to get the diff and then apply ldiff. The problem is I cannot store whole git-log result in the memory. Even the diff contents of a specified file can explode my memory. So then I only query for a small amount of commits each time. This makes my program extremely slow. It takes about half hour to analyze a file in a project with 15000 commits. Then I refactor my code based on git internal api. It turns out to work very well. Now the program can finish in 10sec instead of half hour. And now I can also apply my tool to larger project like linux kernel. So if I want other people to use my tool, I firstly add an entry on the webpage, and then other interested people can get my tool by cloning from my git branch? > (1) We won't know how useful and interesting your contribution be > for our audience, until we see it; and > > (2) If you truly believe in your work (find it useful, find writing > it fun, etc.), that would be incentive enough for you to work > on it, whether or not the result will land in my tree. You > should instead aim for something so brilliant that we would > come to you begging for your permission to include it in our > project. > > I think it applies to your inquiry as well. You are definitely right. Actually I have spent a lot of time on my tool. I just want to know if there are some issues that I should know, otherwise it will prevent me from publishing it or prevent it from becoming a standard git built-in tool. Thanks -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html