On Wed, Oct 03, 2012 at 06:33:39PM -0700, Junio C Hamano wrote: > Read grep.extendedregexp, grep.patterntype, etc. from the > configuration so that "log --grep='<pcre>'" honors the user > preference without an explicit -P from the command line. > > Now that the callback parameter, which was so far unused, to > git_log_config() has to be of type "struct rev_info *", stop passing > it down to git_diff_ui_config(). The latter does not currently take > any callback parameter, and when it does, we would need to make a > structure that has rev info and that parameter and pass it to > git_log_config() anyway, and until that happens, passing NULL will > be less error prone.
Hmm. So I think this is a nice feature for some people, but I wonder if we would run into any plumbing compatibility issues. People do tend to use "log" as plumbing (since rev-list is not as capable). On the other hand, I'd think most internal uses of "log --grep" would be passing something along from the user, and the user would be happy to have it interpreted by their chosen set of rules. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html