Am 05.08.2016 um 00:39 schrieb Junio C Hamano:
@@ -955,12 +955,10 @@ void **nedpindependent_comalloc(nedpool *p, size_t elems, 
size_t *sizes, void **
  */
 char *strdup(const char *s1)
 {
-       char *s2 = 0;
-       if (s1) {
-               size_t len = strlen(s1) + 1;
-               s2 = malloc(len);
+       size_t len = strlen(s1) + 1;
+       s2 = malloc(len);
+       if (s1)


It does not make sense to check s1 for NULL when it was passed to strlen() earlier; strlen() does not accept NULL, either...

                memcpy(s2, s1, len);
-       }
        return s2;
 }
 #endif

-- Hannes

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to