On Sun, Aug 07, 2016 at 10:53:34AM +0200, Johannes Schindelin wrote: > On Sat, 6 Aug 2016, René Scharfe wrote: > > > Call strbuf_add_unique_abbrev() to add abbreviated hashes to strbufs > > instead of taking detours through find_unique_abbrev() and its static > > buffer. This is shorter and a bit more efficient. > > And less error-prone. > > It is also a thing I need to change in my upcoming rebase--helper patches: > I had not known about this function.
Great. I added it several months ago to avoid some hairy allocation code, so I am glad to see it finding new uses (both this patch and potential new ones). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html