Junio C Hamano <gits...@pobox.com> writes:
> Eric Sunshine <sunsh...@sunshineco.com> writes:
>> On Tue, Aug 9, 2016 at 12:08 AM, Stefan Beller <sbel...@google.com> wrote:
>>> t7408: modernize style
>>> Signed-off-by: Stefan Beller <sbel...@google.com>
>>> diff --git a/t/t7408-submodule-reference.sh b/t/t7408-submodule-reference.sh
>>> @@ -8,74 +8,76 @@ test_description='test clone --reference'
>>> +test_expect_success 'that reference gets used with add' '
>>> + (
>>> + cd super/sub &&
>>> + echo "0 objects, 0 kilobytes" > expected &&
>> Since you're modernizing the style, perhaps drop the space after '>'
>> here and elsewhere.
>>> + git count-objects > current &&
>>> + diff expected current
>> Modern practice is to call this 'actual' rather than 'current', but
>> perhaps that's outside the scope of this patch(?).
> Not just that, modern practice is to use "test_cmp" not "diff".
Sorry, hit the "send" too soon, before writing "But all of that
comes in the next step."
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html