On Wed, Aug 10, 2016 at 06:58:06PM +0200, Michael Haggerty wrote:
> > And it looks like rchgo[io] always ends the loop on a 0. So it seems
> > like we would just hit that condition again.
> Correct...in this loop. But there is another place where `io` is
> incremented unconditionally. In the version before my changes, it is via
> the preincrement operator in this while statement conditional:
> After my changes, the unconditional increment is more obvious because I
> took it out of the while condition:
> (BTW, I think this is a good example of how patch 2/8 makes the code
> easier to reason about.)
Ah, yeah, I totally missed that case (and I agree the code after your
2/8 makes it much more obvious).
> I didn't do the hard work to determine whether `io` could *really* walk
> off the end of the array, but I don't see an obvious reason why it
Yeah, I'm in agreement.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html