Jakub Narębski <jna...@gmail.com> writes:

>> +                    else {
>> +                            opts->gpg_sign = buf.buf + 2;
>> +                            strbuf_detach(&buf, NULL);
>
> Wouldn't we leak 2 characters that got skipped?  Maybe xstrdup would
> be better (if it is leaked, and not reattached)?

An attempt to avoid leaking by calling free(opts->gpg_sign) would
make it crash, which would be even worse ;-).

Reply via email to