On Wed, Aug 31, 2016 at 11:46 PM, Stefan Beller <sbel...@google.com> wrote:
> On Sat, Aug 27, 2016 at 11:45 AM, Christian Couder
> <christian.cou...@gmail.com> wrote:
>> extern int check_apply_state(struct apply_state *state, int force_apply);
> With greater scope comes greater responsibility. Nit of the day:
> In case a reroll is necessary, consider putting a comment here.
> (What are these constants? what do they control? How/where do I use them?)
>> +#define APPLY_OPT_INACCURATE_EOF (1<<0)
>> +#define APPLY_OPT_RECOUNT (1<<1)
Ok I will reroll with some added comments.