Am 04.09.2016 um 09:49 schrieb Johannes Schindelin:
Hi René,

On Sat, 3 Sep 2016, René Scharfe wrote:

Add and use a helper function that decodes the char value of two
hexadecimal digits.  It returns a negative number on error, avoids
running over the end of the given string and doesn't shift negative

I like it! Maybe stress a little bit why this is a good change? Like, DRY
up code, makes the code safer (bt avoiding shifting negative values)?

 6 files changed, 21 insertions(+), 78 deletions(-)

Very, very nice!

That's the main reason: Consistency. It's intended to be a safe, easy to use and reasonably fast replacement for those other (lengthy) variations.


Reply via email to