On Fri, 9 Sep 2016, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schinde...@gmx.de> writes:
> > Instead of dying there, let the caller high up in the callchain
> > notice the error and handle it (by dying, still).
> > The only callers of checkout_fast_forward_to(), cmd_merge(),
> > pull_into_void(), cmd_pull() and sequencer's fast_forward_to(),
> > already check the return value and handle it appropriately. With this
> > step, we make it notice an error return from this function.
> > So this is a safe conversion to make checkout_fast_forward_to()
> > callable from new callers that want it not to die, without changing
> > the external behaviour of anything existing.
> > Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de>
> > ---
> I'll retitle this to
> sequencer: lib'ify chckout_fast_forward()
> and checkout_fast_forward_to() in the second paragraph to match the
> reality. Other than that, the above analysis matches what I see in
> the code and the libification done here looks correct.
Good catch. Please also fix it in the third paragraph. (I changed it also
locally, in case a v4 is required.)