On September 14, 2016 3:32:11 PM EDT, Stefan Beller <sbel...@google.com> wrote:
>I think we could chop off "2>&1" as that would have exposed the
>underlying error.
>Another way to go would be to use verbose git-add and grep for
>the string "add '$sm_path'".
>     if test -z "$force" && ! git add --verbose --dry-run
>--ignore-missing "$sm_path" |grep "add $sm_path"
>git-add already gives the correct (the same error message) for  the
>ignored files, so maybe we'd just do:
>    # no need for a if, but this single line will do:
>    test -z "$force" && git add --dry-run git.o >/dev/null || exit 1

FWIW Imho exposing error is good but not sufficient alone, since custom 
gitignore message would still be confusing.
Sent from a phone which beats iPhone.

Reply via email to