"Philip Oakley" <philipoak...@iee.org> writes: > At the moment the cherry-pick man page's example implies that > --do-walk is applied from the beginning, rather from the point given > on the command line. > > I had a very quick search of the *.c code for the options but didn't > get any further. Hopefully the user issue/misunderstanding is > elsewhere... I'll add this to my little list.
I think the confusion is coming from not understanding that revision specifiers cannot have position-dependent semantics, because there is no "union of multiple sets". You said commits in 'master..next' range and the tip of 'maint' earlier, and that is a prime specimen of that confusion. That is asking "things reachable from next excluding things reachable from master" computed independently from everything else on the command line (i.e. that is one set), and "the commit at the tip of 'maint'" (i.e. that is another set, which consists of a singleton element), and wanting to take a union of it. But the revision machinery is not structured to work that way. It can only do "reachable from one enumeration of positive tips, excluding ones reachable from another enumeration of negative tips". "no-walk" is a cheap hack that tells the machinery "stop after collecting that 'one enumeration of positive tips' and do not walk. Make that enumeration the resulting set". Having anything negative in the enumeration of starting points from the command line automatically turns "no-walk" off, even for commands that default to "no-walk". We may need further documentation updates to unconfuse readers.