On Thu, Oct 18, 2012 at 02:17:01AM -0700, Junio C Hamano wrote: > Jeff King <p...@peff.net> writes: > > > It's possible that switching it would create bugs elsewhere (there are > > over 100 uses of strbuf_detach, so maybe somebody really does want this > > NULL behavior), but I tend to think it is just as likely to be fixing > > undiscovered bugs. > > Yeah, I tend to agree. > > This "format-patch --notes" is obviously a post 1.8.0 topic, and so > is the strbuf_detach() clean-up. Let me bookmark this thread in > case it hasn't been resolved when I came back from my vacation, so > that I won't forget ;-).
Actually, I have found a few segfaults, one of them remotely triggerable in http-backend. I think it can probably wait until post-1.8.0 as it does not have any security implications, though. Details in a moment. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
