On Mon, Oct 10, 2016 at 02:59:35PM -0400, Jeff King wrote: > > I must be reading the patch incorrectly, but I cannot quite tell > > where I want astray... > > No, we don't come here from %C() at all. This is for bare "%Cred", which > cannot have "always" (or "auto"), as there is no syntactic spot for it. > It is mostly historical (it _only_ supports red, green, and blue). We > could actually leave this as-is to show the colors unconditionally. I > changed it to keep the new behavior consistent, but I doubt anybody > cares much either way.
Speaking of consistent behavior, if we do this, I think we should give "%(color:red)" in for-each-ref and tag the same treatment. That requires some infrastructure refactoring to get the value down to the ref-formatting code. I'm working on it, but might not have it out today. -Peff
