On Thu, Oct 20, 2016 at 10:50 AM, Junio C Hamano <gits...@pobox.com> wrote: > Stefan Beller <sbel...@google.com> writes: > >> Not sure what triggered the new finding of coverity as seen below as the >> parse_commit() was not touched. Junios series regarding the merge base >> optimization touches a bit of code nearby though. >> >> Do we want to replace the unchecked places of parse_commit with >> parse_commit_or_die ? > > The reason parse_commit() would fail at this point would be because > the repository is corrupt, I do not think it would hurt to do such a > change. > > I agree that it is curious why it shows up as a "new defect", > though. > > By the way, do you know who is managing the service on our end > (e.g. approving new people to be "defect viewer")?
I do it most of the time, but I did not start managing it. And I have been pretty lax/liberal about handing out rights to do stuff, because I did not want to tip on anyone's toes giving to few rights and thereby annoying them. I see that some of these emails may be inconvenient to you, I can change your role to defect viewer/contributor if you prefer. Thanks, Stefan
