On Wed, Oct 24, 2012 at 10:03:35AM +0200, Krzysztof Mazur wrote:

> The git-send-email always use RFC2047 subject quoting for files
> with "broken" encoding - non-ASCII files without Content-Transfer-Encoding,
> even for ASCII subjects. Now for ASCII subjects the RFC2047 quoting will be
> skipped.
> [...]
> -     if ($broken_encoding{$t} && !is_rfc2047_quoted($subject)) {
> +     if ($broken_encoding{$t} && !is_rfc2047_quoted($subject) &&
> +                     ($subject =~ /[^[:ascii:]]/)) {

Is that test sufficient? We would also need to encode if it has rfc2047
specials, no?

It looks like we use the same regex elsewhere. Maybe this would be a
good chance to abstract out a needs_rfc2047_quoting while we are in the

Other than that, I did not see anything wrong with the patch.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to