On Wed, Nov 9, 2016 at 5:01 AM, Jacob Keller <jacob.kel...@gmail.com> wrote:
> On Tue, Nov 8, 2016 at 12:11 PM, Karthik Nayak <karthik....@gmail.com> wrote:
>
>>
>> -               if (starts_with(name, "refname"))
>> +               if (starts_with(name, "refname")) {
>>                         refname = ref->refname;
>> -               else if (starts_with(name, "symref"))
>> +                       if (ref->kind & FILTER_REFS_DETACHED_HEAD)
>> +                               refname = get_head_description();
>
> Since this (I think?) changes behavior of refname would it make sense
> to add a test for this?
>

At the moment there is no way to check this, since this option is not used by
git for-each-ref or git tag (both of which completely use ref-filter
ATM). This is
however tested as eventually git branch uses ref-filter.

-- 
Regards,
Karthik Nayak

Reply via email to