On Oct 21, 2012, at 12:06 , Junio C Hamano <gits...@pobox.com> wrote:
>> This solves errors in some cases when syncing renamed files.
> Can you be a bit more descriptive?  What are "errors in some case"?
It might just be when files are renamed. I ran into this after months of using 
it, and I'm skeptical that in that time no files were ever renamed. I'm not 
sure what was special about the file that was renamed. (There also might have 
been deleted files in the same commit, not sure if that matters)

> In short, what I am getting at are:
> - What breaks by not passing "-s"?  What are the user visible
>   symptoms?

There's a key error on the line
line 2198:        epoch = details["time"]
The details object is an error different fields set (I don't remember what it 
is exactly, I'm not at work right now)

> - Why is it a bug not to pass "-s"?  How does the bug happen?

I encountered this one time after using it for months. One day I couldn't git 
p4 rebase with the key error.  I searched for the error and found some version 
of git-p4 that fixed a similar error by adding the -s to describe. Adding the 
-s fixed the error and everything seemed to be working correctly.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to