Michael J Gruber <g...@drmicha.warpmail.net> writes: > Junio C Hamano venit, vidit, dixit 14.11.2016 19:01: >> Michael J Gruber <g...@drmicha.warpmail.net> writes: >> >>> *My* idea of --no-index was for it to behave as similar to the >>> --index-version as possible, regarding formatting etc., and to be a good >>> substitute for ordinary diff. The proposed patch achieves exactly that - >> ... > It's not clear to me what you are saying here - 1/2 makes git diff > follow symbolic links, yes, just like ordinary diff.
Yes, which can be seen as deviating from your earlier "as similar to the --index version as possible" goal, which I think was where Dscho's complaint comes from. I _think_ the no-index mode was primarily for those who want to use our diff as a replacement for GNU and other diffs, and from that point of view, I'd favour not doing the "comparing symbolic link? We'll show the difference between the link contents, not target" under no-index mode myself. That is a lot closer to the diff other people implemented, not ours. Hence the knee-jerk reaction I gave in http://public-inbox.org/git/xmqqinrt1zcx....@gitster.mtv.corp.google.com
