On Thu, Nov 17, 2016 at 10:46 AM, Brandon Williams <[email protected]> wrote: > v2 of this series is just a small cleanup of removing a nested sub-shell from > a > test and rebasing on the latest version of > 'origin/hv/submodule-not-yet-pushed-fix' > > As stated above this series is based on > 'origin/hv/submodule-not-yet-pushed-fix'
an interdiff to v1 would be nice :) Now t5531 is inconsistent in style, how much time would you estimate to add a commit to refactor that test to follow the style with excessive use of -C for all the other tests and avoiding subshells there, too? (It's mainly Windows that benefits from such a refactoring immediately, but consistency is a really nice feat for the long term code health of the Git project) Apart from one nit (and this refactoring decision/consistency discussion), the series looks good! Thanks, Stefan
