On Fri, Nov 18, 2016 at 9:34 PM, Christian Couder <christian.cou...@gmail.com> wrote: > On Mon, Nov 7, 2016 at 10:38 AM, Duy Nguyen <pclo...@gmail.com> wrote: >> (sorry I got sick in the last few weeks and could not respond to this >> earlier) > > (Yeah, I have also been sick during the last few weeks.) > >> On Mon, Nov 7, 2016 at 4:44 AM, Christian Couder >> <christian.cou...@gmail.com> wrote: >>> Le 6 nov. 2016 09:16, "Junio C Hamano" <gits...@pobox.com> a écrit : >>>> >>>> Christian Couder <christian.cou...@gmail.com> writes: >>>> >>>> > I think it is easier for user to be able to just set core.splitIndex >>>> > to true to enable split-index. >>>> >>>> You can have that exact benefit by making core.splitIndex to >>>> bool-or-more. If your default is 20%, take 'true' as if the user >>>> specified 20% and take 'false' as if the user specified 100% (or is >>>> it 0%? I do not care about the details but you get the point). >> >>> Then if we ever add 'auto' and the user wants for example 10% instead of the >>> default 20%, we will have to make it accept things like "auto,10". > > (Sorry for writing the above on my phone which added HTML, so that it > didn't reach the list.) > >> In my opinion, "true" _is_ auto, which is a way to say "I trust you to >> do the right thing, just re-split the index when it makes sense", "no" >> is disabled of course. If the user wants to be specific, just write >> "10" or some other percentage.(and either 0 or 100 would mean enable >> split-index but do not re-split automatically, let _me_ do it when I >> want it) > > The meaning of a future "auto" option for "core.splitIndex" could be > "use the split-index feature only if the number of entries in whole > index is greater than 10000 (by default)".
Well.. with the "just re-split the index when it makes sense" part, the user entrusts git to do something sensible in all cases, and going with absolute numbers might not be the best way, I think. It's big responsibility :) > If there is no difference between "true" and "auto" then, when users > who have "core.splitIndex=true" will migrate to the git version that > adds the "auto" feature, their repos with under 10000 entires will not > use the split-index feature anymore. These users may then be annoyed > that the behavior has been switched under them, and that the > split-index feature is not always used despite having > "core.splitIndex=true" in their config. -- Duy
