On 2016-12-12 06:53, Torsten Bögershausen wrote:
On 2016-12-12 00:34, Beat Bolli wrote:
We need to track the new commits in uniset, otherwise their and our
code
get out of sync.
Signed-off-by: Beat Bolli <dev+...@drbeat.li>
---
Junio, these go on top of my bb/unicode-9.0 branch, please.
Thanks!
update_unicode.sh | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/update_unicode.sh b/update_unicode.sh
index 4c1ec8d..9ca7d8b 100755
--- a/update_unicode.sh
+++ b/update_unicode.sh
@@ -14,6 +14,11 @@ fi &&
http://www.unicode.org/Public/UCD/latest/ucd/EastAsianWidth.txt
&&
if ! test -d uniset; then
git clone https://github.com/depp/uniset.git
+ else
+ (
+ cd uniset &&
+ git pull
If upstream has accepted your patches, that's nice.
Minor question, especially to the next commit:
Should we make sure to checkout the exact version, which has been
tested?
In this case cb97792880625e24a9f581412d03659091a0e54f
And this is for both a fresh clone and the git pull
needs to be replaced by
git fetch && git checkout cb97792880625e24a9f581412d03659091a0e54f
(Which of course is a shell variable)
I was actually wondering what the policy was for adding submodules to
the Git repo,
but then decided against it. Another option would be to fork uniset on
GitHub and
just let it stay on a working commit.
Junio, what's your stance on this?
Beat
