Christian Couder <christian.cou...@gmail.com> writes:

> +test_expect_success 'set core.splitIndex config variable to true' '
> +     git config core.splitIndex true &&
> +     : >three &&
> +     git update-index --add three &&
> +     git ls-files --stage >ls-files.actual &&
> +     cat >ls-files.expect <<EOF &&
> +100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0    one
> +100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0    three
> +100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0    two
> +EOF
> +     test_cmp ls-files.expect ls-files.actual &&

It does not add much value to follow the "existing" outdated style
like this when you are only adding new tests.  Write these like

        cat >ls-files.expect <<-\EOF &&
        100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0       one
        100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0       three
        100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0       two
        EOF

which would give incentive to others (or yourself) to update the
style of the existing mess ;-).

Reply via email to