On 01/02/2017 05:19 AM, Jeff King wrote: > On Sun, Jan 01, 2017 at 12:36:11PM -0800, Jacob Keller wrote: > >> But how likely is it to end up with differing binaries running on the >> exact same repository concurrently? Basically, I am trying to see >> whether or not we could accidentally end up causing problems by trying >> to race with other git processes that haven't yet been made safe >> against race? Is the worst case only that some git operation would >> fail and you would have to retry? > > Yes, I think that is the worst case. > > A more likely scenario might be something like a server accepting pushes > or other ref updates from both JGit and regular git (or maybe libgit2 > and regular git). > > IMHO it's not really worth worrying about too much. Certain esoteric > setups might have a slightly higher chance of a pretty obscure race > condition happening on a very busy repository. I hate to say "eh, ship > it, we'll see if anybody complains". But I'd be surprised to get a > single report about this.
I agree. I think these races would mostly affect busy hosting sites and result in failed updates rather than corruption. And the races can already occur whenever the user runs `git pack-refs`. By contrast, the failure to delete empty directories is more likely to affect normal users. That being said, if Junio wants to merge all but the last two patches in one release, then merge the last two a release or two later, I have no objections. Michael
