On Sun, Jan 08, 2017 at 05:13:33PM +0700, Nguyễn Thái Ngọc Duy wrote:
> If you have a 256 colors terminal (or one with true color support), then
> the predefined 12 colors seem limited. On the other hand, you don't want
> to draw graph lines with every single color in this mode because the two
> colors could look extremely similar. This option allows you to hand pick
> the colors you want.
>
> Even with standard terminal, if your background color is neither black
> or white, then the graph line may match your background and become
> hidden. You can exclude your background color (or simply the colors you
> hate) with this.
I like this approach much more than the 256-color option.
> * I'm not going with the cumulative behavior because I think that's
> just harder to manage colors, and we would need a way to remove
> colors from the config too.
Yeah, figuring out the list semantics would be a pain. This makes it
hard to exclude a single color, but I think it's more likely somebody
would want to replace the whole set with something that works well
against their background.
> +test_expect_success 'log --graph with merge with log.graphColors' '
> + test_config log.graphColors " blue , cyan , red " &&
This funny syntax isn't required, right? It should work with the more
natural:
test_config log.graphColors "blue, cyan, red"
-Peff
