Hi Junio, On Sun, 8 Jan 2017, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schinde...@gmx.de> writes: > > > This is uglier than a simple > > > > touch "$GIT_EXEC_PATH/use-builtin-difftool" > > > > of course. But oh well. > > That is totally irrelevant. > > The more important point is that we do the same set of tests so > instead of running just one, we run BOTH. And the most important point is that we do all of this only during a hopefully brief period in time that is mostly spent on reviewing the code and finding serious bugs and fixing them. During that period (which I would expect to be spent completely inside `pu`), the cross-validation does not have to be beautiful, but correct. And even more importantly: it has to come at a minimal integration cost, in case David decides to add another test case to t7800. And after that period, we retire the Perl script and switch to the builtin difftool and simply drop this patch to cross-validate both difftools' outputs with one another. At which point all of this safe-guarding and indenting and all of those changes that are just meant to cross-validate the output during that hopefully brief period of time will become moot and all the work spent on those changes will be worthless. Oh, at that point also all review that went into *this* patch will have been spent in vain. In short: can we please move on to reviewing the *actual* builtin difftool and spend our effort on making sure that it is correct? Ciao, Johannes
