I'm not at all attached to changing all of them, just figured it made sense while I was here.
Would a patch that changes only: git-add--interactive.perl | 2 +- git-archimport.perl | 2 +- git-cvsexportcommit.perl | 2 +- git-cvsimport.perl | 2 +- git-cvsserver.perl | 2 +- git-difftool.perl | 2 +- git-relink.perl | 2 +- git-send-email.perl | 2 +- git-svn.perl | 2 +- be more acceptable? On Thu, Jan 12, 2017 at 1:27 AM, Johannes Sixt <j...@kdbg.org> wrote: > Am 12.01.2017 um 06:51 schrieb Pat Pannuto: >> >> diff --git a/git-add--interactive.perl b/git-add--interactive.perl >> index cf6fc926a..6d7b6c35d 100755 >> --- a/git-add--interactive.perl >> +++ b/git-add--interactive.perl >> @@ -1,4 +1,4 @@ >> -#!/usr/bin/perl >> +#!/usr/bin/env perl > > > This change, and all others that affect installed external git programs, is > a no-go. On Windows, our execve emulation is not complete. It would invoke > only `env` (looked up in PATH), but not pass 'perl' as argument. > > Sorry for the bad news. > > I would have suggested to set PERL_PATH in your config.mak, but that does > not change the generated perl scripts, I think. Perhaps you should implement > that? > > I'm not thrilled about your changes to the test scripts, but I do not expect > that they break on Windows. > > -- Hannes >
