> > Hrm. Maybe I am missing something, but what does: > > > > verify_and_format_tag(sha1, name, fmt, flags); > > > > get you over: > > > > gpg_verify_tag(sha1, name, flags); > > pretty_print_ref(name, sha1, fmt); > > > > ? The latter seems much more flexible, and I do not see how the > > verification step impacts the printing at all (or vice versa). > > > > I could understand it more if there were patches later in the series > > that somehow used the format and verification results together. But I > > didn't see that. > > Having read through the rest of the series, it looks like you'd > sometimes have to do:
IIRC, we did this to make the diff "simpler". It also feeds odd that the
call chain is the following:
verify_and_format_tag()
gpg_verify_tag()
run_gpg_verification()
I'm afraid that adding yet another wrapper would further convolute the
call chain. If you think this is not an issue, I could easily do it. Do
you have any suggested name for the wrapper?
Thanks!
-Santiago
signature.asc
Description: PGP signature
