Hi Peff,

On Thu, 19 Jan 2017, Jeff King wrote:

> diff --git a/remote.c b/remote.c
> index 298f2f93f..720d616be 100644
> --- a/remote.c
> +++ b/remote.c
> @@ -373,6 +373,8 @@ static int handle_config(const char *key, const char 
> *value, void *cb)
>       }
>       remote = make_remote(name, namelen);
>       remote->origin = REMOTE_CONFIG;
> +     if (current_config_scope() == CONFIG_SCOPE_REPO)
> +             remote->configured = 1;
>       if (!strcmp(subkey, "mirror"))
>               remote->mirror = git_config_bool(key, value);
>       else if (!strcmp(subkey, "skipdefaultupdate"))
> 
> That doesn't make your test pass, but I think that is only because your
> test is not covering the interesting case (it puts the new config in the
> repo config, not in ~/.gitconfig).
> 
> What do you think?

Heh. After skimming the first three paragraphs of your mail, I had a
similar idea and implemented it. It works great!

v2 coming right up,
Johannes

Reply via email to