On Thu, Feb 2, 2017 at 10:55 AM, Kyle Meyer <[email protected]> wrote: > Hello, > > As of 6311cfaf9 (init: do not set unnecessary core.worktree, > 2016-09-25), "git init --separate-git-dir" no longer sets core.worktree > (test below). Based on the commit message and the corresponding thread > [1], I don't think this change in behavior was intentional, but I wasn't > able to understand things well enough to attempt a patch.
I'm missing some context. Why does --separate-git-dir have to set core.worktree? What fails for you exactly? > > Thanks. > > [1] > https://public-inbox.org/git/calqjkkzo_y0dncrjjooyz7eso7ybmghvz6fe92oo4su7jec...@mail.gmail.com/T/#u > > diff --git a/t/t0001-init.sh b/t/t0001-init.sh > index b8fc588b1..444e75865 100755 > --- a/t/t0001-init.sh > +++ b/t/t0001-init.sh > @@ -309,6 +309,7 @@ test_expect_success 'init with separate gitdir' ' > git init --separate-git-dir realgitdir newdir && > echo "gitdir: $(pwd)/realgitdir" >expected && > test_cmp expected newdir/.git && > + check_config realgitdir false "$(pwd)/newdir" && > test_path_is_dir realgitdir/refs > ' > -- Duy
