On Tue, Feb 14, 2017 at 11:08:05AM -0800, Junio C Hamano wrote:
> Thanks for prodding. I'm tempted to just rip out everything other
> than the 5-liner fix to transport.c and apply it, expecting that a
> follow-up patch with updated tests to come sometime not in too
> distant future.
I think we can at least include one basic test. Also, as it turns out
the problem I was seeing _wasn't_ the same one Jonathan fixed. There's
another bug. :)
So here's a patch series that fixes my bug, and then a cut-down version
of Jonathan's patch. I'd be happy to see more tests come on top. I don't
think there's a huge rush on getting any of this into master. There are
bugs in the existing code, but they're very hard to trigger in practice
(e.g., a non-repo which happens to have a bunch of repo-like files). It
only becomes an issue in 'next' when we die("BUG") to flush these cases
out.
[1/2]: remote: avoid reading $GIT_DIR config in non-repo
[2/2]: remote helpers: avoid blind fall-back to ".git" when setting GIT_DIR
remote.c | 2 +-
t/t5512-ls-remote.sh | 9 +++++++++
t/t5550-http-fetch-dumb.sh | 9 +++++++++
transport-helper.c | 5 +++--
4 files changed, 22 insertions(+), 3 deletions(-)
-Peff
