Matthieu Moy <matthieu....@grenoble-inp.fr> writes:
> Siddharth Kannan <kannan.siddhart...@gmail.com> writes:
>
>> This is as per our discussion[1]. The patches and commit messages are based
>> on
>> Junio's patches that were posted as a reply to
>> <20170212184132.12375-1-gits...@pobox.com>.
>>
>> As per Matthieu's comments, I have updated the tests, but there is still one
>> thing that is not working: log -@{yesterday} or log -@{2.days.ago}
>
> Note that I did not request that these things work, just that they seem
> to be relevant tests: IMHO it's OK to reject them, but for example we
> don't want them to segfault. And having a test is a good hint that you
> thought about what could happen and to document it.
The branch we were on before would be a ref, and the ref may know
where it was yesterday? If @{-1}@{1.day} works it would be natural
to expect -@{1.day} to, too, but there probably is some disambiguity
or other reasons that they cannot or should not work that way I am
missing, in which case it is fine ("too much work for too obscure
feature that is not expected to be used often" is also an acceptable
reason) to punt or deliberately not support it, as long as it is
explained in the log and/or doc (future developers need to know if
we are simply punting, or if we found a case where it would hurt end
user experience if we supported the feature), and as long as it does
not do a wrong thing (dying with "we do not support it" is OK,
segfaulting or doing random other things is not).
Thanks.
