On Thu, Feb 23, 2017 at 5:25 PM, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: >> +int option_parse_recurse_submodules(const struct option *opt, >> + const char *arg, int unset) > > Again, this function should be marked static. > > [I also noted _two_ other local functions with the same name > in builtin/fetch.c and builtin/push.c]
fixed in a reroll. Yes there is a pattern here. But as both fetch and push accept different options (not just boolean, but strings) these have to be different. I thought about unifying them, but I do not think we can do so easily. Thanks, Stefan
