Hi Junio, On Fri, 3 Mar 2017, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schinde...@gmx.de> writes: > > > Notable notes: > > > > - In contrast to earlier versions, I no longer special-case init and > > clone. Peff pointed out that this adds technical debt, and that we can > > actually argue (for consistency's sake) that early config reads the > > current repository config (if any) even for init and clone. > > > > - The read_early_config() function does not cache Git directory > > discovery nor read values. If needed, this can be implemented later, > > in a separate patch series. > > > > - The alias handling in git.c could possibly benefit from this work, but > > again, this is a separate topic from the current patch series. > > As Peff said in his review, I too find the result of this series a > more pleasant read than than original. As do I. > 2/9 and corresponding 4/9 triggers "ERROR: trailing statements > should be on next line" from ../linux/scripts/checkpatch.pl because > of a line inherited from the original; I'll queue them with an > obvious style fix to work it around. Thank you. I'll try to pick it up for v3 (which is needed, as I found another issue that needs to be fixed). Ciao, Johannes
