Ævar Arnfjörð Bjarmason <[email protected]> writes:
> The ^{<type>} suffix could be changed to be case-insensitive as well
> without introducing any ambiguities. That was included in an earlier
> version of this patch, but Junio objected to its inclusion in [2].
We try not to be personal in our log message. It's not like my
objection weighs heavier than objections from others. The same
number of bytes in the log message can better to spent to allow
readers of "git log" independently to judge the rationle without
referring to external material.
Perhaps replace this entire paragraph, including the URL in [2],
with something like
The ^{type} suffix is not made case-insensitive, because other
places that take <type> like "cat-file -t <type>" do want them
case sensitively (after all we never declared that type names
are case insensitive). Allowing case-insensitive typename only
with this syntax will make the resulting Git as a whole
inconsistent.
Other than that, the change to the code and the new tests all makes
sense to me.
Thanks.
