One more quesestion regarding flags used in structures : for example: update_callback_data has a flags field (type int) , in function void update_callback() the field flags of that structure is used as param for add_file_to_index(..., data->flags) and this function is define as: int add_file_to_index(..., int flags) in read-cache.c The question is : If the flags field of the structure is used in function calls should i update flags that deep?(there are other cases where the field is used in nested calls )
On Sun, Apr 2, 2017 at 6:30 AM, Junio C Hamano <[email protected]> wrote: > Robert Stanca <[email protected]> writes: > >> I am used to 1change per patch so it's easier to redo specific >> patches...if there are small changes(10 lines max) can i send them as >> 1 patch? > > It's not number of lines. One line per patch does not make sense if > you need to make corresponding changes to two places, one line each, > in order to make the end result consistent. If you change a type of > a structure field, and that field is assigned to a variable > somewhere, you would change the type of both that field and the > variable that receives its value at the same time in a single > commit, as that would be the logical unit of a smallest change that > still makes sense (i.e. either half of that change alone would not > make sense). > > >
