> On 04 Apr 2017, at 17:20, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: > > > > On 04/04/17 00:53, David Turner wrote: >> Unfortunately, in order to push some large repos, the http postbuffer >> must sometimes exceed two gigabytes. On a 64-bit system, this is OK: >> we just malloc a larger buffer. >> >> This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the >> buffer size. >> >> Signed-off-by: David Turner <dtur...@twosigma.com> >> --- >> >> V5 addresses comments from Torsten Boegershausen and Ramsay Jones. Since >> I don't have a 32-bit machine handy, it's difficult for me to check >> for compiler warnings on 32-bit machines. Hopefully my guess as >> to the solution to Ramsay's issue will be correct. > > Yep, this compiles without complaint.
Hi David, You can test the 32-bit build on your machine by ... 1. Pulling this Docker image: https://github.com/git/git/blob/cf11a67975b057a144618badf16dc4e3d25b9407/.travis.yml#L58 2. Starting the Docker image: https://github.com/git/git/blob/cf11a67975b057a144618badf16dc4e3d25b9407/.travis.yml#L72 3. Running the linux32 build: https://github.com/git/git/blob/cf11a67975b057a144618badf16dc4e3d25b9407/.travis.yml#L73 Cheers, Lars
