On Thu, Apr 20, 2017 at 12:41 PM, Brandon Williams <bmw...@google.com> wrote: > On 04/18, Stefan Beller wrote: >> v2: >> * improved commit message to be proper English (Thanks, Philip!) >> * clarified why the patch 2 is so short (i.e. it doesn't matter if the >> submodule >> is initialized in the preparation repo, we care about the actual testing >> repo! >> Thanks, Brandon) > > That was the only thing I was unsure about in v1. v2 lgtm.
Thanks for the review. Well the last commit still needs a better commit message as Junio pointed out, so might just resend the last patch with better wording.
