On Fri, Apr 21, 2017 at 2:48 AM, Junio C Hamano <[email protected]> wrote: > SZEDER Gábor <[email protected]> writes: > >> We had two similar bugs in the tests sporadically triggering error >> messages during the removal of the trash directory, see commits >> bb05510e5 (t5510: run auto-gc in the foreground, 2016-05-01) and >> ef09036cf (t6500: wait for detached auto gc at the end of the test >> script, 2017-04-13). The test script succeeded nonetheless, because >> these errors are ignored during housekeeping in 'test_done'. >> >> However, such an error is a sign that something is fishy in the test >> script. Print an error message and abort the test script when the >> trash directory can't be removed successfully or is already removed, >> because that's unexpected and we woud prefer somebody notice and
s/woud/would/ >> figure out why. > Note, that the commit message references ef09036cf (t6500: wait for >> detached auto gc at the end of the test script, 2017-04-13), which >> is still only in 'pu'. > > I think that one is already part of 2.13-rc0 ;-) Yeah, I should have fetched before submitting.
