Hi Johannes, On Tue, 2017-05-02 at 17:34 +0200, Johannes Schindelin wrote: > Hi Liam, > > On Tue, 2 May 2017, Liam Beguin wrote: > > > teach `git rebase -i` to recognise short command-names when using the > > '--autosquash' option. This allows commit with titles beginning with > > "s! ..." and "f! ..." to be treated the same way as "squash! ..." and > > "fixup! ..." respectively. > > As the recommended way to generate those commits is by using the > --fixup/--squash options of git-commit, and as there is *a much higher* > chance of false positives when using a very short tell-tale such as `f!` > (which could be an abbreviation for an expletive, likewise `s!`), I do not > think we will want this change. > > Let's keep handling just fixup!/squash! > > Ciao, > Johannes
I was not quite sure about this change. My guess was that since --autosquash needs the whole commit title to find a match, the short version had little probability of generating a false positive. I thought it made sense to include the change in this series, but I understand why it's probably not a good idea to take it. I'll remove it in the next series. Thanks, Liam
